Skip to content

Martinh/spl deployment guide #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

martin0995
Copy link
Collaborator

Description

  • Add standalone guide for creating and minting Solana SPL tokens to support NTT deployments.
  • Replaced dropdown in the Solana NTT deployment guide with a link to the new page.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A0 - New Content Pull request contains new content pages label Jun 11, 2025
@martin0995 martin0995 added the B0 - Needs Review Pull request is ready for review label Jun 11, 2025
@martin0995 martin0995 requested a review from ilariae June 11, 2025 16:19
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not totally sure about this page — might be worth checking with Evgeni. I remember moving this content into its own ## section before, and he asked me to put it back. It’s helpful but not a required step or Wormhole-specific.

Keeping it in an expandable section keeps users on the page, and since it’s not something they’ll do often or need to reference elsewhere, I’m not sure it needs to be its own page.

@martin0995
Copy link
Collaborator Author

I’m not totally sure about this page — might be worth checking with Evgeni. I remember moving this content into its own ## section before, and he asked me to put it back. It’s helpful but not a required step or Wormhole-specific.

Keeping it in an expandable section keeps users on the page, and since it’s not something they’ll do often or need to reference elsewhere, I’m not sure it needs to be its own page.

Waiting for Evgeni's reply on this

@martin0995
Copy link
Collaborator Author

@eshaben @dawnkelly09, got confirmation that this should not be included in our docs. Closing this PR.

@martin0995 martin0995 closed this Jun 18, 2025
@martin0995 martin0995 deleted the martinh/spl-deployment-guide branch June 18, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants